-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #481
base: master
Are you sure you want to change the base?
Develop #481
Conversation
Please set a versioning label of either |
eca80f7
to
caa91fc
Compare
VOLUME_DATA=/home//wikigdrive | ||
VOLUME_PREVIEW=/home//wikigdrive-preview | ||
DOMAIN=localhost | ||
DOMAIN=http://localhost:3000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we no longer need RENDER_IMAGE
, VOLUME_DATA
and VOLUME_PREVIEW
?
maybe we should consider adding here placeholders for variables related to JWT and zipkin URL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In https://github.com/mieweb/wikiGDrive/blob/develop/website/docs/developer-guide.md#running-locally-with-docker we specify those env variables in docker run
command
I we use both .env
file and -e RENDER_IMAGE...
it's not clear which env would be used by wikigdrive.
|
||
jobs: | ||
test: | ||
if: github.event.pull_request.head.ref != 'develop' && contains( github.event.pull_request.labels.*.name, 'deploy-pr') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we want to limit it? Does building/testing take too much time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wikigdrive starts watching each shared drive for changes. It seems that the more watchers we use the slower they work. Each additional instance is another set of connections to the API.
apps/ui/assets/main.css
Outdated
|
||
.prism-editor__editor { | ||
font-size: 16px; | ||
font-family: monospace !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it work without !important
? If not, maybe it would be better to use an id instead of a class as CSS selector?
No description provided.